Skip to content

Add customDomainMode parameter for Pages

Naman Jagdish Galarequested to merge
ngala/pages-custom-domain-mode into master

What does this MR do?

Add customDomainMode parameter for Pages. To know the detailed proposal why this parameter was added, please refer here.

This is only targeted for Rails change without any changes in Pages code base.

Testplan 1:

For the new parameter, we have added unit tests.

Testplan 2:

Ran below command:

helm template gitlab . \
  --timeout 600s \
  --set global.image.pullPolicy=Always \
  --set global.hosts.domain=gcp.example.com \
  --set global.hosts.externalIP=1.2.3.4 \
  --set certmanager-issuer.email=me@example.com \
  --set global.hosts.pages.name=pages.gcp.example.com \
  --set global.pages.customDomainMode=https \
  --set global.pages.enabled=true > test.yaml

Got below output:

      pages:
        enabled: true
        access_control: false
        artifacts_server: true
        path: /srv/gitlab/shared/pages
        host: pages.gcp.example.com
        port: 443
        https: true
        secret_file: /etc/gitlab/pages/secret
        external_http: false
        external_https: false
        custom_domain_mode: https

Changelog: added

Related issues

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

  • Merge Request Title and Description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline.
  • Documentation created/updated.
  • Tests added/updated, and test plan for scenarios not covered by automated tests.
  • Equivalent MR/issue for omnibus-gitlab opened: gitlab-org/omnibus-gitlab!8419 (merged)

Reviewers checklist

Edited by Naman Jagdish Gala

Merge request reports