feat: extraHosts for Ingress and extraIngress
What does this MR do?
This MR adds extra hostnames support for the Webservice Ingress and extraIngress components to enable users access GitLab Webservice with additional DNS records.
Related issues
Solves 3147
Author checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow
For merge requests from forks, consider the following options for Danger to work properly:
- Consider using our community forks instead of forking your own project. These community forks have the GitLab API token preconfigured.
- Alternatively, see our documentation on configuring Danger for personal forks.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added/updated -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes) -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Merge request reports
Activity
added 1st contribution Community contribution labels
added linked-issue label
added devopssystems group::distributiondeploy labels
added sectioncore platform label
mentioned in issue #3147
mentioned in issue gitlab-org/quality/triage-reports#17802 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17803 (closed)
added groupdistribution label
assigned to @idankalmanzon
mentioned in issue gitlab-org/quality/triage-reports#17832 (closed)
added featureaddition label
added typefeature label
1 Warning Please check the QA job and compare with builds on master
. If no new failures are reported in QA job, add QA:verified label.1 Message If this is a wider community contribution, the Community contribution label should be added. Once your MR is ready for review you can comment
@gitlab-bot ready <@user>
to request the first review to someone. It's recommended that you pick the one suggested by the reviewer roulette. But you can ignore it and assign it to someone else if you see fit.Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response from the reviewer within the SLO, please mention
@gitlab-org/distribution
, or one of our Project MaintainersReviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @rutgerwessels
(UTC+2)
@Alexand
(UTC+0)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerThanks so much for the contribution, @idankalmanzon.
Unfortunately, the reviewer roulette suggesting a reviewer, like above, does not yet get automatically triggered in forked projects. So I triggered a pipeline to help us find a reviewer. For future contributions, I'd recommend experimenting contributing through the GitLab community forks, which are aimed to provide a more fluid experience. But there's no need to move this MR there.
@deriamis could you kindly take this review request? @gitlab-bot ready @deriamis
Edited by João Alexandre Cunha
added workflowready for review label
requested review from @deriamis
Hi
@lyspin
! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.added documentation twtriaged labels
requested review from @lyspin
marked the checklist item When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow as completed