Skip to content

Set GOMEMLIMIT for Gitaly container

Emily Chui requested to merge ec/set-gomemlimit-gitaly into master

What does this MR do?

Setting this env variable can help avoid OOM related errors induced by the Go garbage collector. Go is not aware of what the container's memory limits are, by setting this we can configure a soft memory limit. It will be more aggressive running gc cycles (increasing cpu usage) getting closer to the limit and try to use all the live heap before increasing more memory for the heap.

Related issues

Related issue: gitlab-org/gitaly#6067

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

For merge requests from forks, consider the following options for Danger to work properly:

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by João Alexandre Cunha

Merge request reports