Skip to content

Require upgrade stop at 16.11/chart 7.11

Clemens Beck requested to merge 5450-upgrade-stop-16-11 into master

What does this MR do?

Require upgrade stop at 16.11/chart 7.11

GitLab 16.11/chart 8.11 is an required upgrade stop for 17.0/8.0.

https://docs.gitlab.com/ee/update/#upgrade-paths

Changelog: changed

Related issues

Closes #5450 (closed)

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Test Plan

#!/bin/bash

mkdir chart-info

# Usage:
#   test OLD_VERSION OLD_CHART_VERSION NEW_VERSION NEW_CHART_VERSION [SUFFIX]
test_runcheck() {
  echo "${1}" > chart-info/gitlabVersion
  echo "${2}" > chart-info/gitlabChartVersion

  docker run \
    --rm -t \
    -v ${PWD}/templates/_runcheck.tpl:/scripts/runcheck \
    -v ${PWD}/chart-info:/chart-info \
    -e GITLAB_VERSION="${3}" \
    -e CHART_VERSION="${4}" \
    "registry.gitlab.com/gitlab-org/build/cng/gitlab-base:master${5}" \
    /bin/sh /scripts/runcheck > /dev/null && echo 'PASS' || echo 'FAIL'
}

# PASS

test_runcheck '16.11.0' '7.11.0' '17.0.0' '8.0.0'
test_runcheck '16.11.1' '7.11.1' '17.0.0' '8.0.0'
test_runcheck '16.11.1' '7.11.1' '17.1.0' '17.1.0'

# FAIL

test_runcheck '16.10.0' '7.10.0' '17.0.0' '8.0.0'
test_runcheck '16.10.3' '7.10.3' '17.0.0' '8.0.0'
test_runcheck '15.11.0' '6.11.0' '17.0.0' '8.0.0'
test_runcheck '16.11.0' '7.10.0' '17.0.0' '8.0.0'

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

For merge requests from forks, consider the following options for Danger to work properly:

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Clemens Beck

Merge request reports