Skip to content

Adds support for custom annotations to minio PVC

  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do?

This MR adds support for passing custom annotations to the MinIO PVC. As mentioned in #3001 this is useful for keeping the PVC around after removing the deployment.

I also added a warning into the NOTES after a deployment to detect this specific use case. Informing the user that this isn't supported by GitLab as setting this annotation can imply they are going for a more "production ready" deployment of MinIO.

Related issues

Closes #3001

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

For merge requests from forks, consider the following options for Danger to work properly:

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA I think this does not apply, normal tests are provided.
  • Equivalent MR/issue for omnibus-gitlab opened Helm Chart only feature, not affecting omnibus
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes) Helm Chart only feature, default values are still valid, no change to operator necessary
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Marcel

Merge request reports