Skip to content

Improve registry GCS example

Stan Hu requested to merge sh-improve-registry-google-adc-docs into master

What does this MR do?

It wasn't clear how to configure Google Application Default credentials with the registry, so this commit adds some comments and updates the documentation link.

The previous link to https://docs.docker.com/registry/storage-drivers/gcs no longer exists. The CNCF docs in https://distribution.github.io/distribution/storage-drivers/gcs/ are correct today, but it's possible that the CNCF docs adds or changes parameters that are not supported by the GitLab Container Registry. Still, the documentation there is better than nothing.

In the future, we may want to sync storage driver changes with the CNCF project (gitlab-org/container-registry#1240).

Related issues

Relates to #3434

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

For merge requests from forks, consider the following options for Danger to work properly:

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Plum

Merge request reports