CI: Cleanup PersistentVolumeClaims after all other resources
What does this MR do?
CI: Cleanup PersistentVolumeClaims last
Cleanup PVC after all other resources have been cleanup up, and print debugging info about the underlying PV and volume.
This no longer deletes PVs directly, instead relying on the ReclaimPolicy
for deletion. However, we print out some PV information in the logs for awareness.
Relates gitlab-org/distribution/team-tasks#1429 (closed)
Related issues
Author checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow
For merge requests from forks, consider the following options for Danger to work properly:
- Consider using our community forks instead of forking your own project. These community forks have the GitLab API token preconfigured.
- Alternatively, see our documentation on configuring Danger for personal forks.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes - Install a chart release
- source the autodevops script
- set
RELEASE_NAME
andNAMESPACE
env variables - run
cleanup
- Note: The changes do not run in CI until merged, since CI always uses the script from master.
-
Documentation created/updated -
Tests added/updated -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes) -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Mitchell Nielsen