Skip to content

Replace .Release.Revision in Job names with timestamp

Clemens Beck requested to merge 3832-replace-revision-usage into master

What does this MR do?

Replace usages of .Release.Revision with timestamp

Improve support for helm template based tools such as Helmfile and ArgoCD by replacing .Release.Revision with timestamp values.

The release revision is always evaluated to 1 and can not be overridden when helm template is invoked.

Changelog: changed

Related issues

Closes #3832 (closed)

Relates #734 (closed)

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Test plan

  1. Install a release
  2. Confirm that the Job names have the expected timestamps
  3. Upgrade the release
  4. Confirm that the Job names have the expected timestamps and do not collide with previous Job names

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Clemens Beck

Merge request reports

Loading