CI: Pin tags for helper images
What does this MR do?
Pin tags for helper images
The helper image tags were not pinned as part of the changes in !3435 (merged), which would cause problems - for example, on stable branches, these helper images would try to reference semver tags instead of stable branch tags due to the logic calculation that looks in Chart.yaml.
Related issues
Related to #5109 (closed)
Follow-up to !3435 (merged)
Test plan
- Simulate each scenario (set
GITLAB_VERSION
, thenCI_COMMIT_BRANCH
, thenCI_MERGE_REQUEST_TARGET_BRANCH_NAME
). - Confirm the output in
ci.digests.yaml
looks as expected. - Use the YAML manifest in
helm template
, grep forcng
, and ensure each of the image tags are set correctly.
Author checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added/updated -> see #5111 (closed) -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes) -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Mitchell Nielsen