Skip to content

Draft: Update zoekt to 0.8.1

Dmitry Gruzd requested to merge update-zoekt-to-0-8-1 into master

What does this MR do?

This MR updates gitlab-zoekt to 0.8.1 to fix GitLab.com Chart Bump failing in staging due to... (gitlab-com/gl-infra/delivery#19793 - closed)

The problem appears when gitlab-zoekt goes from 0.7.0 to 0.8.0 if the LoadBalancer is set.

Screenshots or screen recordings

Click to expand

zoekt_0_8_1.svg

How to test

  1. Obtain an internal IP address in GCP and set it with export INTERNAL_IP=<INTERNAL_IP>
  2. Set gitlab-zoekt chart version to 0.7.0 in requirements.yaml
  3. Run helm dependency update
  4. Install the helm chart with
helm install gitlab . \
--set certmanager-issuer.email=email@example.com \
--set gitlab-zoekt.install=true \
--set gitlab-zoekt.service.type=LoadBalancer \
--set gitlab-zoekt.service.loadBalancerIP=$INTERNAL_IP
  1. Set gitlab-zoekt chart version to 0.8.0 in requirements.yaml
  2. Run helm dependency update
  3. Upgrade the helm chart
helm upgrade gitlab . \
--set certmanager-issuer.email=email@example.com \
--set gitlab-zoekt.install=true \
--set gitlab-zoekt.service.type=LoadBalancer \
--set gitlab-zoekt.service.loadBalancerIP=$INTERNAL_IP
  1. Ensure that it fails with spec.clusterIPs[0]: Invalid value: []string{"None"}: may not change once set
  2. Set gitlab-zoekt chart version to 0.8.1 in requirements.yaml
  3. Run helm dependency update
  4. Upgrade the helm chart
helm upgrade gitlab . \
--set certmanager-issuer.email=email@example.com \
--set gitlab-zoekt.install=true \
--set gitlab-zoekt.service.type=LoadBalancer \
--set gitlab-zoekt.service.loadBalancerIP=$INTERNAL_IP

Related issues

gitlab-com/gl-infra/delivery#19793 (closed)

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Dmitry Gruzd

Merge request reports