Remove comment from traefik-tcp-ingressroute.yaml template
What does this MR do?
Remove the comment from the template as it results in an error in the IngressRouteTCP.
The generated spec with the error :
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRouteTCP
metadata:
name: gitlab-gitlab-shell
namespace: gitlab
labels:
app: gitlab-shell
chart: gitlab-shell-7.4.1
release: gitlab
heritage: Helm
spec:
entryPoints:
- gitlab-shell
routes:
- match: HostSNI(`*`)
services:
- name: gitlab-gitlab-shell
namespace: gitlab
port: 32022# https://doc.traefik.io/traefik/routing/services/#proxy-protocol
proxyProtocol:
version: 2
It should be :
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRouteTCP
metadata:
name: gitlab-gitlab-shell
namespace: gitlab
labels:
app: gitlab-shell
chart: gitlab-shell-7.4.1
release: gitlab
heritage: Helm
spec:
entryPoints:
- gitlab-shell
routes:
- match: HostSNI(`*`)
services:
- name: gitlab-gitlab-shell
namespace: gitlab
port: 32022
proxyProtocol:
version: 2
Author checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added/updated -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes) -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Menco Bolt