Skip to content

Draft: Fix spec selector for login username/email

Clemens Beck requested to merge fix-spec-login-selectors into master

What does this MR do?

Fix spec selector for login username/email

The username/email label was changed to "Username or primary email" in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/130779.

This causes review_specs_* to fail with:

Failures:
  1) Restoring a backup Restored gitlab instance Home page should show projects
     Failure/Error: fill_in 'Username or email', with: 'root'
     Capybara::ElementNotFound:
       Unable to find field "Username or email" that is not disabled within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/DIV[1]/DIV[1]/DIV[1]/DIV[3]/DIV[1]/DIV[1]/DIV[1]/DIV[1]">

Example job: https://gitlab.com/gitlab-org/charts/gitlab/-/jobs/5038933773

Related issues

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Merge request reports