Skip to content

Introduce the Roulette 2nd attempt

João Alexandre Cunha requested to merge revert-e7c5cb48 into master

What does this MR do?

We attempted to introduce the reviewer roulette, but we broke our pipelines on dev.gitlab.org. So we reverted the MR. Now we're bringing the same changes back, with a small commit on top that fixes what went wrong.

This second attempt reverts Revert "Merge branch 'jcunha/add-reviewer-roule... (!3317 - merged), i.e. it re-introduces the roulette. Additionally, it adds the necessary fix as another commit on top of it:

Additional commit: !3319 (d476b7a3)

Define danger-review job before including danger-review template

To not duplicate ourselves, we want to include the danger-review
definition from gitlab-org/quality/pipeline-common. But this project
only exists in gitlab.com. So, we cant rely on the `script` tag defined
there to be the sole definition for the `script` tag inside the
danger-review job. This is because, when we trigger a pipeline in
dev.gitlab.org, the aforementioned template doesnt exist and the
danger-review job would end up with no script tag, which breaks the
pipeline parsing.

By defining the job before including the template, we can create a
`no-op` script tag just so that the pipeline is correctly parsed in
dev.gitlab.org. But the job needs to be defined before including the
template because, for the cases where we do include the template, we
want the template script definition to override the `no-op` job
definition.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by João Alexandre Cunha

Merge request reports