Skip to content

Add MR checklist item for considering Operator impact

Mitchell Nielsen requested to merge docs-update-mr-checklist into master

What does this MR do?

Similar to the Omnibus checklist item, adds an
Operator checklist item to ensure that any changes
to Charts are considered in the context of the
Operator project.

Clarifies that the checklist is expected to
be completed by the author.

Updates the 'Tests added' checklist item
to more closely match the 'Documentation added/updated'
line, since changes may only require tests being updated
and not added.

Related issues

Closes gitlab-org/distribution/team-tasks#1331 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Hossein Pursultani

Merge request reports