Skip to content

fix(toolbox): Use the minio endpoint when generating the configmap

Joel Low requested to merge lowjoel/gitlab-chart:fix-kube-internal-service into master

What does this MR do?

fix(toolbox): Use the minio endpoint when generating the configmap

When using a cluster-local minio, the endpoint is a service that may not utilise HTTPS. For a Chart install with the ingress disabled, this means that backups do not work properly.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Joel Low

Merge request reports