Skip to content

Fix image branch naming assumptions in autodevops.sh

Jason Young requested to merge 4747-fix-image-branch-naming into master

What does this MR do?

Fix image branch naming assumptions in autodevops.sh

Due to the changes introduced by gitlab-org/release-tools!2362
in populating a leading `v` into the appVersion - this had a
cascade effect in image_branch having a leading `v` - causing
the image tag for the stable branch to erroneously be set to
`vX-Y-stable`

This removes the leading `v` coming from appVersion when used
to match an image with the correct stable branch name.

Changelog: fixed
Signed-off-by: Jason Young <jyoung@gitlab.com>

Related issues

Closes #4747 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Young

Merge request reports