Skip to content

Skip pages backup on database upgrade

Clemens Beck requested to merge upgrade-database-dont-backup-pages into master

What does this MR do?

Skip pages backup on database upgrade

When a database upgrade is performed, a backup
is made during the `pre` stage.
This backup must not include the GitLab pages
object storage backup.

Changelog: fixed

Related issues/MRs

Based on: !3143 (comment 1379993996)

Relates !3143 (merged)

Testing

Prerequisite: kubectl context points to a cluster/namespace with a GitLab chart release

export REVISION=5efab9266397750252a457a230cddffee87c9143 # latest sha pushed to this MR
export HELM_RELEASE=test
curl -s "https://gitlab.com/gitlab-org/charts/gitlab/-/raw/${REVISION}/scripts/database-upgrade" | bash -s -- -r ${HELM_RELEASE} pre

Expectation:

  • GitLab Pages object storage is not backed up
  • Database is backed up

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Hossein Pursultani

Merge request reports