fix: gitlab_shell enable condition in nginx_ingress about deployment and daemonset
What does this MR do?
fix: gitlab_shell enable condition in nginx_ingress about deployment and daemonset
.Values.controller.service.enableShell
logic should be consistent in all nginx_ingress chart template, contains the service deployments and daemonset, The current logic is that only service is expected.
controller-service:
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by yuanxiongxiong