Skip to content

Add the gitlab/gitlab-zoekt chart as optional (disabled) dependency

Dylan Griffith requested to merge add-gitlab-zoekt-as-optional-dependency into master

What does this MR do?

This chart can be found at https://gitlab.com/gitlab-org/cloud-native/charts/gitlab-zoekt and should be published to charts.gitlab.io already. We want to use these optional (disabled by default) dependency to allow us to install this on GitLab.com . We'll eventually like to support this for self-managed so adding as a dependency of this chart seems like the most efficient step for getting onto GitLab.com.

Read more at gitlab-org/gitlab#384723 (closed)

Related issues

gitlab-org/gitlab#384723 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
    • I wasn't sure what to do here. I've tested installing the gitlab-zoekt chart works and the CI does validate that it can locate this dependency. Additionally there is no autoconfiguration of GitLab discovering Zoekt (as this is done in the DB for now) so there isn't really any logic here to test.
  • Documentation created/updated
  • Tests added
    • It didn't seem useful to add tests for a dependency without any new templating logic being added
  • Integration tests added to GitLab QA
    • This will not be covered by QA until it is released
  • Equivalent MR/issue for omnibus-gitlab opened
    • Given the priority of GitLab.com before supporting self-managed we want to defer omnibus. We're only adding in CNG to make it easier for GitLab.com to deploy it.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
    • There aren't template changes so I don't think this applies
Edited by Jason Plum

Merge request reports