Skip to content

Deprecate sidekiq queueSelector and negateQueues

Gregorius Marco requested to merge mg-deprecate-queue-selector into master

What does this MR do?

Add deprecation notice Sidekiq's queueSelector and negateQueues option.

The actual deprecation/removal will be on separate MR due in 17.0 (as per gitlab-org/gitlab#390787)

Equivalent Omnibus MR: gitlab-org/omnibus-gitlab!6676 (merged)

Related issues

Deprecation issue: gitlab-org/gitlab#390787

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Plum

Merge request reports