Fix certmanager http01 solver on "none" ingress class
requested to merge clemensbeck/gitlab:3712-cert-manager-issuer-created-with-ingress-class-none into master
What does this MR do?
Fixes an issue where "none"
is rendered to the HTTP01 ingress solver's class when setting global.ingress.class=none
. This option is used to set neither the Ingress Class annotation nor the spec field (depending on API version) of Ingresses.
Solution: Do not render the http01.ingress.class
field in case of a none
value. This results in cert-manager creating new ingresses without setting the ingress class (see: HTTP01 Ingress solver class).
Related issues
Closes #3712 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Mitchell Nielsen