Skip to content

Add redisYmlOverride config setting

Jacob Vosmaer requested to merge jv-redis-yml-override into master

What does this MR do?

This adds a new setting global.redis.redisYmlOverride which allows administrators to render arbitrary settings into the GitLab config/redis.yml file. Also see gitlab-com/gl-infra/scalability#2063 (closed).

This commit will not break anything because the application still reads the old Redis config files and those will take precedence over an empty redis.yml file.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened gitlab-org/omnibus-gitlab!6609 (merged)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jacob Vosmaer

Merge request reports