Skip to content

Test helper: Fix helm version regexp to not require patch level

Matthias Käppler requested to merge mk-fix-helm-version-matcher into master

What does this MR do?

I wasn't able to run specs locally, because the helm spec helper checks for the current helm version using a regexp that requires a patch level to exist in the version string.

However, my current helm version was 3.5 (no patch level):

$ helm version -c                                               
version.BuildInfo{Version:"v3.5", GitCommit:"", GitTreeState:"", GoVersion:"go1.16.6"}

This then did not match the version string and just returns nil.

Since we are not inspecting the patch level anyway, we might as well drop this requirement.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports