Skip to content

Ensure secretName behavior consistency for mutual TLS

Mitchell Nielsen requested to merge 3406-tls-secretname-consistency into master

What does this MR do?

Ensures consistency in the TLS secretName pattern amongst components by removing the check that a user manually provides the secretName value.

Instead, we'll provide a default name. Pods relying on this Secret will fail to start until that Secret is made available.

This is a favorable solution as it removes many checks in the codebase. That said, we could go with the alternative and check every single component for a valid secretName.

Related issues

Closes #3406 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports