Skip to content

Override NGINX Controller image to v1.2.1

Mitchell Nielsen requested to merge 3403-update-nginx-controller-image into master

What does this MR do?

Override NGINX Controller image to v1.2.1

Overrides the NGINX Ingress Controller image to reference the v1.2.1
tag that is released by our fork in
https://gitlab.com/gitlab-org/charts/gitlab-ingress-nginx.
The digest was taken from the following job:
https://gitlab.com/gitlab-org/cloud-native/charts/gitlab-ingress-nginx/-/jobs/2736356091#L2049

This is intended as a temporary change until
https://gitlab.com/gitlab-org/distribution/team-tasks/-/issues/1090
is addressed, which will remove the in-chart NGINX chart in favor of
the true fork (to be ingested via `requirements.yaml`).

Note that the current in-chart NGINX chart expects v1.0.4 of the NGINX
Ingress Controller. While this change deviates from that version by two
minor versions, required functionality is in tact so far.

Closes https://gitlab.com/gitlab-org/charts/gitlab/-/issues/3403

Related issues

Closes #3403 (closed)

Testing

Ensure desired image is used

☸ gke-cloud-native:helm-charts-win
$ kubectl get po -l app=nginx-ingress,component=controller,release=rvw-3403-update-nginx-controll -ojson | jq '.items[] | .spec.containers[0].image' -r
registry.gitlab.com/gitlab-org/cloud-native/charts/gitlab-ingress-nginx/controller:v1.2.1@sha256:ec5cded8516196f7f263919f632227fef1e346d5c1671ae6cfbe96f4223da775

Ensure full pipeline passes (including QA)

https://gitlab.com/gitlab-org/charts/gitlab/-/pipelines/604111229

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by DJ Mountney

Merge request reports