Skip to content

Puma memory.limits needs to include the primary

Ben Prescott_ requested to merge docs/bprescott/20220802-pumamemory into master

What does this MR do?

Looking at a where the customer is getting lots of OOM events and we suspect it's puma workers.

See my analysis here: gitlab-org/gitlab#332312 (comment 1046571847)

They've set limits.memory for webservice to 2GB, which is less even than the docs which specify 3GB. However, additionally, there will be a Puma primary.

The ~"group::memory" team's current guidance for Puma RSS is here: gitlab-org/gitlab#334831 (comment 1009146926)

This docs revision will take this into account and ensure that if OOM is measuring using RSS, it doesn't set the threshold too low. When set to 3GB, that would allocate 1.025GB to each worker (default, two workers) which is less than the 1.5GB we document that we're allocating.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports