Skip to content

Respect NGINX defaultbackend default (disabled)

Mitchell Nielsen requested to merge disable-nginx-defaultbackend into master

What does this MR do?

Removes the override that enables the NGINX Ingress Controller's defaultbackend component, which is disabled by default upstream.

Further context in https://gitlab.com/gitlab-org/cloud-native/gitlab-operator/-/issues/420#note_1034435917

Implication: upon upgrade to this version, the NGINX defaultbackend Deployment will be deleted. The NGINX Ingress Controller Deployment will also be updated, but there shouldn't be any noticeable interruption as the Deployment/ReplicaSet swaps out the Pods.

Related issues

Related to https://gitlab.com/gitlab-org/cloud-native/gitlab-operator/-/issues/420

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports