Skip to content

Remove NGINX's `isControllerTagValid` helper

Mitchell Nielsen requested to merge 3392-disable-nginx-tag-check into master

What does this MR do?

Removes NGINX's isControllerTagValid helper.

Related issues

Closes #3392 (closed)

Testing

$ helm template gitlab . --set nginx-ingress.controller.image.tag=foobar --set certmanager-issuer.email=a@b.com --show-only charts/nginx-ingress/templates/controller-deployment.yaml | yq '.spec.template.spec.containers[0].image'
Error: template: gitlab/charts/nginx-ingress/templates/controller-deployment.yaml:2:4: executing "gitlab/charts/nginx-ingress/templates/controller-deployment.yaml" at <include "isControllerTagValid" .>: error calling include: template: gitlab/charts/nginx-ingress/templates/_helpers.tpl:128:12: executing "isControllerTagValid" at <semverCompare ">=0.27.0-0" .Values.controller.image.tag>: error calling semverCompare: Invalid Semantic Version

Use --debug flag to render out invalid YAML
null

$ cd ../3392-disable-nginx-tag-check

$ helm template gitlab . --set nginx-ingress.controller.image.tag=foobar --set certmanager-issuer.email=a@b.com --show-only charts/nginx-ingress/templates/controller-deployment.yaml | yq '.spec.template.spec.containers[0].image'
registry.gitlab.com/gitlab-org/cloud-native/mirror/images/ingress-nginx/controller:foobar@sha256:545cff00370f28363dad31e3b59a94ba377854d3a11f18988f5f9e56841ef9ef

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports