Skip to content

Ensure Azure access and secret keys are JSON in Workhorse config.toml

Stan Hu requested to merge sh-tidy-azure-workhorse-toml into master

What does this MR do?

This mirrors the change made to fix AWS access and secret key rendering with AWS in !2639 (merged).

We probably will never hit a failure with Azure as we did with S3 because there are no third-party options for Azure Blob Storage. In addition, https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview says:

Storage account names must be between 3 and 24 characters in length and may contain numbers and lowercase letters only.

The access key is also a base64-encoded value of binary data, so it won't have any special characters.

Related issues

Follow-up to !2639 (merged).

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports