Skip to content

Add option to specify priorityClassName to the chart and all included subcharts

Robin Elfrink requested to merge equinix-ms/gitlab-charts/gitlab:add-priorityclassname into master

What does this MR do?

This MR adds the option to specify priorityClassName for pods in the chart and all included subcharts.

See the Kubernetes documentation on PriorityClasses for detailed information.

Setting global.priorityClassName in the main values.yaml will result in all pods installed by this chart to be configured with the named PriorityClass, with the exception of GitLab Runner and Prometheus; these subcharts do not inherit global.priorityClassName.

A test has been added that sets global.priorityClassName to system-cluster-critical, and checks if all resulting Deployments and Jobs have priorityClassName: system-cluster-critical in their pod specs.

As a default installation does not include StatefulSets, DaemonSets or CronJobs these are not tested.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Robin Elfrink

Merge request reports