Skip to content

minReadySeconds for supporting staggered rollouts for kas

Mikhail Mazurskiy requested to merge ash2k/min_ready_seconds into master

What does this MR do?

Exposes the minReadySeconds field on the KAS deployment. KAS serves long-running connections, which immediately reconnect on disconnection. KAS itself starts and becomes ready pretty much instantly, so when KAS is restarted, this can create a huge spike of re-connections, putting unnecessary strain on the system. We want to use minReadySeconds to introduce an artifical readiness delay to help stagger our rollouts to and spread out the re-connections.

Related issues

Relates to gitlab-org/cluster-integration/gitlab-agent#172 (closed).

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports