Skip to content

Add support for enabling SSL on Puma

Stan Hu requested to merge sh-support-puma-ssl into master

What does this MR do?

This provides configuration options for configuring the internal SSL port, certificate, and key for the webservice container. If the SSL port is enabled:

  1. Liveness/readiness checks will continue to use HTTP since webservice will still listen for HTTP on 127.0.0.1.
  2. Workhorse will configure its authBackend to talk to HTTPS only if the HTTP external port is disabled.

This requires the changes in gitlab-org/build/CNG!947 (merged).

The public certificate and private key must be provided via the Kubernetes secret name specified in gitlab.webservice.tls.secretName. tls.cert and tls.key must be specified.

Related issues

Part of gitlab-org/gitlab#353013 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports