Fix the fullname of sidekiq to use the "fullname" template helper function
What does this MR do?
It makes sidekiq use the name as defined by the "fullname" helper function. When overriding the "fullname" in a higher chart, sidekiq breaks as it uses "fullname" for configmaps but does not use "fullname" when referencing it. In addition it's impossible to change the sidekiq deployment name.
Related issues
Closes: #3226 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Mitchell Nielsen