Skip to content

Adds support for custom annotations to minio PVC

Nic O'Sullivan requested to merge nicosullivan/gitlab-chart:3001-add-custom-annotations-to-minio into master

What does this MR do?

This MR adds support for passing custom annotations to the MinIO PVC. As mentioned in #3001 this is useful for keeping the PVC around after removing the deployment.

I also added a warning into the NOTES after a deployment to detect this specific use case. Informing the user that this isn't supported by GitLab as setting this annotation can imply they are going for a more "production ready" deployment of MinIO.

Related issues

Closes #3001

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added

I don't think the below apply to this MR, but can update if necessary.

Edited by Nic O'Sullivan

Merge request reports