Skip to content

Support setting image registry and/or repository globally

Mitchell Nielsenrequested to merge
2859-global-image-settings into master

What does this MR do?

  • Supports setting global image registry.
  • Supports setting a digest for an image.

Previously:

sidekiq:
  image:
    repository: custom-repo.com/my-repo/sidekiq:foo
webservice:
  image:
    repository: custom-repo.com/my-repo/webservice:foo
toolbox:
  image:
    repository: custom-repo.com/my-repo/toolbox:foo
# and so on...

Now:

global:
  image:
    registry: custom-repo.com

Also supports setting image digest. For example:

global:
  kubectl:
    image:
      tag: 1.2.3
      digest: sha256:abcd123...
webservice:
  image:
    tag: 1.2.3
    digest: sha256:abcd123...

References

Related issues

Closes #2859

Closes #1896 (closed)

To do

  • Add image.fullpath template
  • Implement image.fullpath for all image: fields
  • Merge together image.pull{Policy,Secrets} templates
  • Add tests for image paths
  • Test upgrade path (helm install gitlab gitlab/gitlab -n gitlab ... -> helm upgrade --install gitlab . -n gitlab ...)
  • Test fresh install path (helm install gitlab . -n gitlab ...)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened

Closes #2859

Edited by Mitchell Nielsen

Merge request reports