Skip to content

Unify mailroom enablement empty checks

Quang-Minh Nguyen requested to merge qmnguyen0711/unify-mail-room-enabled-check into master

What does this MR do?

Extracted from !2358 (comment 827199218)

In the above MR, we noticed that there is an inconsistency of how we check for incomingEmail.enabled and serviceDeskEmail.enabled. One variant follows if eq incomingEmail.enabled true. Another one is if incomingEmail.enabled. This MR is to unify two versions. The empty check is chosen. We didn't fix this issue in that MR to prevent unnecessary file changes.

I don't choose the explicit boolean check because the other variant dominates the whole chart. This can be verified with grep 'if .*enabled' . and grep 'if .*enabled.*true' ..

Related issues

None

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Quang-Minh Nguyen

Merge request reports