Skip to content

fix: skip praefect db secret gen/labeling for external db

Aaron Walker requested to merge boxboat/charts-gitlab:cond-gen-praefect-dbsecret into master

What does this MR do?

This MR will skip generating and labeling the Praefect Postgres secret if a host is specified. This uses the same logic that already for Postgres and Redis passwords.

Related issues

Adding labels to secrets created outside the Helm chart causes inconsistencies with the state of tools used to create those secrets. For example, Terraform detects the labels and removed them, but then the chart adds them back.

Closes #3096 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Aaron Walker

Merge request reports