Skip to content

allow modifying praefect values without requiring praefect.service value

Aaron Walker requested to merge boxboat/charts-gitlab:allow-praefect-values into master

What does this MR do?

This MR allows for specifying Praefect values without the config check complaining about unspecified .Values.praefect.service values. For example, in our use case, we want to modify Praefect resources.

Related issues

No issue created.

Current:

$ helm install gitlab . --set global.praefect.enabled=true --set praefect.resources.cpu="200m" --set certmanager-issuer.email="aaron@boxboat.com"
Release "gitlab" does not exist. Installing it now.
Error: template: gitlab/templates/NOTES.txt:127:3: executing "gitlab/templates/NOTES.txt" at <include "gitlab.checkConfig" .>: error calling include: template: gitlab/templates/_checkConfig.tpl:47:34: executing "gitlab.checkConfig" at <include "gitlab.checkConfig.gitaly.storageNames" .>: error calling include: template: gitlab/templates/_checkConfig_gitaly.tpl:11:15: executing "gitlab.checkConfig.gitaly.storageNames" at <include "gitlab.appConfig.repositories" $>: error calling include: template: gitlab/charts/gitlab/templates/_gitlab.yaml.tpl:11:10: executing "gitlab.appConfig.repositories" at <include "gitlab.praefect.storages" .>: error calling include: template: gitlab/charts/gitlab/templates/_praefect.tpl:6:13: executing "gitlab.praefect.storages" at <include "gitlab.praefect.externalPort" $>: error calling include: template: gitlab/templates/_praefect.tpl:87:29: executing "gitlab.praefect.externalPort" at <.Values.praefect.service.externalPort>: nil pointer evaluating interface {}.externalPort

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports