Skip to content

Unset namespace on NGINX IngressClass (cluster-scoped)

Mitchell Nielsen requested to merge nginx-ingressclass-unset-namespace into master

What does this MR do?

Unset namespace on IngressClass (cluster-scoped)

IngressClasses are cluster-scoped: https://kubernetes.io/docs/concepts/services-networking/ingress/#ingressclass-scope

As such, we don't need to set the namespace on them.

For reference, no namespace is set on the object in the upstream chart: https://github.com/kubernetes/ingress-nginx/blob/controller-v1.0.4/charts/ingress-nginx/templates/controller-ingressclass.yaml

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports