Skip to content

Enhanced support ingressClassName on Ingress resources

Hossein Pursultani requested to merge 2920-ingress-class-name into master

What does this MR do?

This MR supports setting ingressClassName or adding kubernetes.io/ingress.class annotation on Ingress resources based on the API version of Ingress:

  • networking.k8s.io/v1/Ingress use .spec.ingressClassName
  • networking.k8s.io/v1beta1/Ingress use kubernetes.io/ingress.class annotation
  • extensions/v1beta1/Ingress use kubernetes.io/ingress.class annotation

Chart still uses global.ingress.class value to set the ingress class name across all Ingress resources.

This MR also renames some of the template names.

Related issues

Closes #2920 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports