Skip to content

Gitaly: Remove setting location of socket_path

Jenn Power requested to merge jpower1/gitlab:chore/move-location-gitaly-socket-dir into master

What does this MR do?

The purpose of this MR is to move the location of the Gitaly socket path defined in the config.toml to make it a subpath of /home/git so it can be created by the current UID in the running container. When running with the restricted SCC on OpenShift, Gitaly fails to start because the process tries to chmod the socket directory as it starting up.

During review, it was found that a simplified means of addressing the permissions is to not set this value at all, and allow Gitaly to manage a temporary directory for the sockets it will use.

Related issues

Related to gitlab-org/build/CNG!822 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports