Skip to content

[KAS] Move 'global.kas.apiExternalPort' to parent chart

Mitchell Nielsen requested to merge 2905-fix-kas-globals into master

What does this MR do?

Puts 'global.kas.apiExternalPort' in top-level values.yaml because globals should "flow downstream" - meaning the globals should be set in the parent chart for consumption by child/sibling charts.

Helm 3.7.0 includes a change that enforces this approach, meaning that enabling KAS in the GitLab Charts would cause a failure because the Webservice ConfigMap could not find the global.kas.apiExternalPort value (because it was in the KAS chart, its sibling).

Reference issue in Helm project: https://github.com/helm/helm/issues/10154#issuecomment-923120990

Related issues

Closes #2905 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened

Closes #2905 (closed)

Edited by Mitchell Nielsen

Merge request reports