Skip to content

Drop the special ingress rule for /admin/sidekiq

Stan Hu requested to merge sh-drop-admin-sidekiq-ingress into master

What does this MR do?

Sidekiq ships and registers its own Web assets. #689 (closed) added a special ingress rule to direct routes prefaced with /admin/sidekiq/ directly to the Webservice container. This was done because the Workhorse container did not have a copy of the Sidekiq gem, where the assets are stored, so Workhorse would return a 404 error.

gitlab-org/gitlab!70113 (merged) will disable the Sendfile interface for /admin/sidekiq, so we no longer need this special rule since Rails will serve these assets directly.

Related issues

  1. https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/14150
  2. #2731 (closed)

Testing

I made this configuration change, and then found that the /admin/sidekiq page failed to load the CSS and JavaScript.

Then I updated my cluster to the latest master, and verified that the page loaded properly.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Stan Hu

Merge request reports