Skip to content

Add missing configuration items for GitLab Pages feature

John Skarbek requested to merge jts/pages-config into master

What does this MR do?

Numerous options have been identified to be missing for the GitLab Pages feature. Let's ensure our helm chart knows to add them as required by this service. I've chosen to leverage the documentation provided by the service instead of setting defaults. It would seem the defaults for this service are sane as for the .com installation none of these are configured in any special fashion.

Testing

global:
  pages:
    enabled: true
gitlab:
  gitlab-pages:
    gitlabCache:
      cleanup: 1
      expiry: 1
      refresh: 1
    gitlabRetrieval:
      interval: 1
      retries: 1
      timeout: 1
    headers:
      - "Permissions-Policy: interest-cohort=()"
      - "Foo: Bar"
    logVerbose: true
    propagateCorrelationId: true
    statusUri: "/-/readiness"
    zipCache:
      cleanup: 1
      refresh: 1
      expiration: 1
    zipOpenTimeout: 1

When looking at the log output of the service, if verbose is set to true, you'll see that SOME of the configuration items report the values as indicated above. For some reason not all options perform this. For items that do not log in the startup, I'm unsure how else to validate they are being taken in by the Pages service. The values utilized above were strictly for testing purposes only, not of the service, but for ensuring the configuration takes place.

⚠ The last item I know is missing is listen-https-proxyv2; I plan on adding this in a separate MR as this is slightly more involved ⚠

Which is here: !2158 (merged)

Related issues

Addresses: #2823 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA n/a
  • Equivalent MR/issue for omnibus-gitlab opened Omnibus appears to already have these necessary settings.
Edited by John Skarbek

Merge request reports