Skip to content

Adds pages local_store configuration

Craig Miskell requested to merge support-disabling-pages-local-store into master

What does this MR do?

Adds the ability to configure local_store, primarily so that it can be disabled

If not configured explicitly, Rails currently defaults to enabled being 'true' with a default path, but this causes some Sidekiq jobs to pass a guard clause and throw spurious errors when the local directory structure doesn't exist.

It's not out of the question (however unlikely) that someone is relying on the default behavior, is mounting a (possibly shared) volume of some kind at the expected path, and needs that to continue working, so this simply defaults to nil (empty string) for both, which allows the GitLab code to continue to use its default behavior. Those who need to (e.g. gitlab.com) can set enabled to false to fix the problem case.

Related issues

https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/14015

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
    • Not sure; CI tests will pass, what else is required?
  • Documentation created/updated
  • Tests added
    • Existing tests updated to match
  • Integration tests added to GitLab QA
    • QA has no tests for anything of Pages AFAICT.
  • Equivalent MR/issue for omnibus-gitlab opened
    • N/A, this is bringing charts up to parity.
Edited by Craig Miskell

Merge request reports