Skip to content

[nginx-ingress] Update default configuration for HSTS to match upstream and Omnibus defaults

Julian Paul Dasmarinas requested to merge hsts-enabled-default into master

What does this MR do?

Change the default configuration of HSTS. The default configuration of the NGINX Ingress Helm Chart has HSTS set to true.

However, it seems that on this commit, we explicitly set this to false. This value was not set previously so it means that older versions of the Helm chart has HSTS configured by default.

The lack of HSTS after an upgrade was noticed by one of our customers (internal)

Since the Omnibus have HSTS configured by default, I think it's also better to have this configured by default in the Helm chart.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports