Skip to content

Add `gitlab.selectorLabels` template to standardize selector labels

Nathan A Papapietro requested to merge npapapietro/gitlab:DuplicateLabels into master

What does this MR do?

This MR originally started under the context of fixing the remainder of the duplicate labels. There were some templates still using

labels:
  app: {{ template "name" . }}
  release: {{ .Release.Name }}
  {{- include "gitlab.standardLabels" . | nindent 8 }}

when gitlab.standardLabels alone contains the same key, values. Additionally the object gitlab.immutableLabels duplicates keys as well.

After some discussion, this evolved into creating gitlab.selectorLabels because app and release labels as selectors was used so consistently across the charts. This reduces repetition and provides a clearer implementation of selector labels, following a pattern used by other charts such as ingress-nginx.

Related issues

Related to #2582 (closed)

Related to #2809 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports