Skip to content

Document RSpec patterns for values merging

Jason Plum requested to merge 2724-rspec-std-deepmerge into master

What does this MR do?

Per #2724 (closed), we're quite inconsistent on how we make use of merge and deep_merge functions throughout the charts. This adds a paragraph to development/rspec.md regarding the usage of merge patterns within our RSpec, explaining advantages and drawbacks of each, and offering a generalized guideline.

We must improve this in the future.

I've also added HelmTemplate.certmanager_issuer, intended to replace this repeated entry in "all the charts" for let(:default_values).

Related issues

Relates to #2724 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports