Skip to content

Resolve pathType error in smartcard ingress

Silvester Wainaina requested to merge fix-pathtype-error-smartcard into master

What does this MR do?

Follow up MR for !1951 (merged), it seems we introduced a bug with the pathType.

Helm fails to upgrade if smartcard is enabled.

global:
  appConfig:
    smartcard:
      enabled: true
Error: UPGRADE FAILED: template: gitlab/charts/gitlab/charts/webservice/templates/ingress_smartcard.yaml:40:41: executing "gitlab/charts/gitlab/charts/webservice/templates/ingress_smartcard.yaml" at <.ingress.pathType>: nil pointer evaluating interface {}.pathType

This ingress is not using the _datamodel so will set it to it directly as is the case of registry

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports