Skip to content

Remove Pod annotations for AWS IRSA

Gerard Hickey requested to merge 2710-eksRoleArn-removal into master

What does this MR do?

Original development of the AWS IAM role for ServiceAccounts feature was tested with eks.amazonaws.com/role-arn annotation on the sidekiq, task-runner and webservice Pods. Various configurations were tested and there were indications that the annotation needed to be on the Pods. An issue was raised by a user and further testing was performed that shows that the Pod annotation is not needed. The annotation is only required on the ServiceAccount.

This MR reverts the changes to the Pod annotations and updates the documentation accordingly.

Related issues

Closes #2710 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened

The tests checking for the Pod annotations has been removed.

Edited by Gerard Hickey

Merge request reports